Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Add an omit option for tests #564

Merged
merged 1 commit into from
Sep 17, 2015
Merged

Conversation

kcoons
Copy link
Contributor

@kcoons kcoons commented Sep 8, 2015

Add a command line option to omit particular tests using the same format as the -only flag. Add omitted targets/tests to the skipped targets/tests from the scheme.

In "testCanSelectSpecificTestClassOrTestMethodWithOnly", "runWithOnlyArgumentAndExpectSenTestToBe" was taking in a list of expected tests, but it was doing absolutely nothing with them. So, stop sending them in since they're ignored anyway.

Generalize "onlyListAsTargetsAndSenTestList" and make it return a dictionary rather than an array of key value pairs so that we can query whether a given target is in it or not easily.

@"-project", TEST_DATA @"TestProject-Library/TestProject-Library.xcodeproj",
@"-scheme", @"TestProject-Library",
@"-sdk", @"iphonesimulator6.1",
@"build-tests", @"-omit", @"TestProject-LibraryTests",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth testing when multiple -omit is passed.

@ExtremeMan
Copy link
Contributor

Looks great! I liked some architectural changes! I think multiple -omit options won't work =( Please double check and cover with tests ;)

@ExtremeMan
Copy link
Contributor

I've checked out locally and run bunch of different tests with disabled tests, disabled test targets, with -omit and -only options. Looks good. Merging.

ExtremeMan added a commit that referenced this pull request Sep 17, 2015
Add an omit option for tests actions.
@ExtremeMan ExtremeMan merged commit fa804e5 into facebookarchive:master Sep 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants